Transform end-to-end tests into acceptance tests using Behat with in-memory repos #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phaseinducer
commented
Nov 24, 2017
| class: Pim\Test\Common\Persistence\InMemoryAttributeRepository | ||
|
|
||
| pim_catalog.repository.attribute: | ||
| alias: pim_catalog.saver.attribute |
There was a problem hiding this comment.
Yeah it looks weird but I didn't find another way to use the same instance for two different services :/
| class: Pim\Test\Common\Persistence\InMemoryAttributeRepository | ||
|
|
||
| pim_catalog.repository.attribute: | ||
| alias: pim_catalog.saver.attribute |
| @@ -22,6 +22,9 @@ | |||
| "classmap": [ "app/AppKernel.php", "app/AppCache.php", "tests/AppKernelTest.php" ] | |||
| }, | |||
| "autoload-dev": { | |||
| "psr-4": { | |||
| "Pim\\Test\\": "tests/" | |||
There was a problem hiding this comment.
if that was meant only for behat, you could move it in the autoload part of behat.yml (not really important I think)
There was a problem hiding this comment.
It can be used by something else than Behat imho.
| @@ -0,0 +1,27 @@ | |||
| imports: | |||
There was a problem hiding this comment.
we don't see how you decide which kernel environment to use (I guess in your behat.yml ?)
There was a problem hiding this comment.
You're right ! I forgot to push the Behat conf. Here it is : https://github.com/akeneo/pim-community-dev/pull/7209/files#diff-7bde54db60a6e933518d8b61b929edceR121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This POC is a follow-up to #7157.
The idea is the same : find a way to transform end-to-end tests into other more relevant and efficient types of tests.
The first POC was very naive and pragmatic, this time I wanted to go further and try to use Behat with Symfony integration to be able to use the DI.
About the tests themselves
I chose validation scenarii as a simple (but not so much at the end) work base.
The old tests were end-to-end, they used :
The goal was to find a way to focus on the business logic.
First step : rework the Gherkin to remove all notions of UI components and call directly business services from the new Behat context. The UI behavior can still be tested by other end-to-end tests.
About how I reworded the tests : I discussed a lot with @jjanvier and @Delphineray about the fact that it should be possible to validate a value collection without using a product (technically we're really close to be able to do it). Indeed, a value collection could be seen as a standalone entity and can be contained by something else, a product model for instance. So it could make sense even from a functional point of view.
Anyway we didn't find any good solution, it looks like it's still not a well defined concept, or at least we couldn't find a common (technical/functional) way to talk about it.
So for the moment i chose to mention products in the Gherkin, it can change later.
Technical solution
Then, to avoid calling the database I used an in-memory repository when needed (for these use cases only the attribute repository was called).
To do that, I needed :
I also created a brand new Behat context. Still not sure about the naming, the files organisation, the steps design, the stateful behavior, how to split it later... Feel free to propose ideas and vision.
Possible next steps
Try it
Launch
bin/behat --profile=acceptance --suite=acceptanceon your machine.